Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/piwoo 432 early wp texturize #952

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Fix/piwoo 432 early wp texturize #952

merged 4 commits into from
Oct 21, 2024

Conversation

mmaymo
Copy link
Collaborator

@mmaymo mmaymo commented Oct 15, 2024 •
edited by jira bot
Loading

Handles PIWOO-432

mmaymo added 4 commits April 10, 2024 10:33
@mmaymo
update modularity
8cff9c5 
it fails with php7.2
@mmaymo
Merge branch 'refs/heads/develop' into fix/PIWOO-432-early-wp-texturize
3baeeb7 
# Conflicts:
#	composer.json
#	composer.lock
#	lib/packages/Inpsyde/Modularity/Container/ContainerConfigurator.php
#	lib/packages/Inpsyde/Modularity/Container/PackageProxyContainer.php
#	lib/packages/Inpsyde/Modularity/Container/ReadOnlyContainer.php
#	lib/packages/Inpsyde/Modularity/Package.php
#	lib/packages/Inpsyde/Modularity/Properties/PluginProperties.php
#	lib/packages/Inpsyde/Modularity/Properties/ThemeProperties.php
#	lib/packages/Psr/Container/ContainerExceptionInterface.php
#	lib/packages/Psr/Container/ContainerInterface.php
#	lib/packages/Psr/Container/NotFoundExceptionInterface.php
@mmaymo
Delete old scoped lib file
73eb2be
@mmaymo
Update composer lock
a03a19a
inpsyde-maticluznar
inpsyde-maticluznar approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@inpsyde-maticluznar inpsyde-maticluznar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modularity has been updated from version 1.5.1 to 1.10.0 in the composer.lock file. I'm not sure what changes were made to the package or how they might affect this plugin. To be safe, I suggest doing at least happy path testing.

@mmaymo mmaymo merged commit c4b5be5 into develop Oct 21, 2024
8 checks passed
@mmaymo mmaymo deleted the fix/PIWOO-432-early-wp-texturize branch October 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inpsyde-maticluznar inpsyde-maticluznar inpsyde-maticluznar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmaymo @inpsyde-maticluznar